Dear Mike,
In message 1230623965-16546-1-git-send-email-vapier@gentoo.org you wrote:
Rather than special casing each environment type for enabling the saveenv command, have them all behave the same. This avoids bitrot as new env sources are added/removed.
Signed-off-by: Mike Frysinger vapier@gentoo.org
common/cmd_nvedit.c | 26 ++++++++------------------ 1 files changed, 8 insertions(+), 18 deletions(-)
This patch breaks support for the
This board is a bit unusual as it is ROM based - it has CONFIG_ENV_IS_IN_FLASH set because the default environment is embedded in the ROM, but does not enable the flash driver (because there is no flash on the board). So the test in "common/cmd_nvedit.c":
549 #if defined(CONFIG_CMD_ENV) && !defined(CONFIG_ENV_IS_NOWHERE)
fails - it enables do_saveenv(), but there is no underlying saveenv() function. Result:
common/libcommon.a(cmd_nvedit.o): In function `do_saveenv': common/cmd_nvedit.c:557: undefined reference to `saveenv' make: *** [u-boot] Error 1
Please fix.
Best regards,
Wolfgang Denk