Hi,
On Tue, Dec 11, 2012 at 4:30 AM, Wolfgang Denk wd@denx.de wrote:
Dear Hatim Ali,
In message 1355223289-15685-8-git-send-email-hatim.rv@samsung.com you wrote:
From: Alim Akhtar alim.akhtar@samsung.com
Adds a new u-boot command to read current temprature from tmu driver.
Signed-off-by: Alim Akhtar alim.akhtar@samsung.com Acked-by: Simon Glass sjg@chromium.org
Do we really need a new command here?
We already have dtt, which basicly does the same.
It makes no sense to add new commands for each new device, all doing basicly trhe same, just in an incompatible way.
This patch feature does not use i2c as the temperature measurement is inside the SOC. I wonder whether cmd_dtt.c could be extended so that it only does the i2c stuff if CONFIG_SYS_DTT_BUS_NUM is defined. Then you could use dtt_get_temp() to get the termperature as now.
Regards, Simon
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de The explanation requiring the fewest assumptions is the most likely to be correct. -- William of Occam _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot