Yuli Barcohen yuli@arabellasw.com wrote:
No, they aren't. First of all, on big-endian systems __LITTLE_ENDIAN is never defined and on little-endian systems it's always defined automatically while CFG_FLASH_CFI_SWAP must be defined manually if your board has such a flash. On little-endian systems, the driver should work without the need to define CFG_FLASH_CFI_SWAP. Also, there are places in the code for __LITTLE_ENDIAN only, not for CFG_FLASH_CFI_SWAP.
Seems your explaination is not the same as your patch:-). I hope I weren't clear this time.
In your patch, CFG_FLASH_CFI_SWAP is automatically defined in __LITTLE_ENDIAN case. So on __LITTLE_ENDIAN system, CFG_FLASH_CFI_SWAP MUST BE ENABLED by default.
+#if defined(__LITTLE_ENDIAN) && !defined(CFG_FLASH_CFI_SWAP) +#define CFG_FLASH_CFI_SWAP +#endif
Regards,
Sam
___________________________________________________________ Mp3疯狂搜-新歌热歌高速下 http://music.yahoo.com.cn/?source=mail_mailbox_footer