Hi Detlev,
some more small style issues, see comments below.
Detlev Zundel wrote:
diff --git a/drivers/rtc/rtc4543.c b/drivers/rtc/rtc4543.c new file mode 100644 index 0000000..242d9bc --- /dev/null +++ b/drivers/rtc/rtc4543.c @@ -0,0 +1,118 @@
...
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
----------------------------------------------------------^ please, remove space here.
<snip>
+/*
- Note: The acrobatics below is due to the hideously ingenius idea of
- the chip designers. As the chip does not allow register
-------------------------^ please, remove space here.
- addressing, all values need to be read and written in one go. Sure
-------------------------------------------------------------------^ please, remove space here.
<snip>
+int rtc_get(struct rtc_time *tm) +{
- int rel = 0;
- uchar buffer[7];
- memset(buffer, 0, 7);
- /* Read 52 bits into our buffer */
- tws_read(buffer, 52);
- tm->tm_sec = BCD2BIN( buffer[0] & 0x7F);
- tm->tm_min = BCD2BIN( buffer[1] & 0x7F);
- tm->tm_hour = BCD2BIN( buffer[2] & 0x3F);
- tm->tm_wday = BCD2BIN( buffer[3] & 0x07);
------------------------------^ please, remove space here.
- tm->tm_mday = BCD2BIN((buffer[3] & 0xF0) >> 4 | (buffer[4] & 0x0F) << 4);
- tm->tm_mon = BCD2BIN((buffer[4] & 0x30) >> 4 | (buffer[5] & 0x0F) << 4);
- tm->tm_year = BCD2BIN((buffer[5] & 0xF0) >> 4 | (buffer[6] & 0x0F) << 4) + 2000;
these tree lines above are too long.
...
diff --git a/include/rtc.h b/include/rtc.h index 785fbe3..019c2eb 100644 --- a/include/rtc.h +++ b/include/rtc.h @@ -61,4 +61,8 @@ void to_tm (int, struct rtc_time *); unsigned long mktime (unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int);
+uchar rtc_read(uchar reg) __attribute__((weak)); +void rtc_write(uchar reg, uchar val) __attribute__((weak));
remove one blank line here, please.
Best regards, Anatolij