On 09/05/2018 05:15 AM, Tom Rini wrote:
On Wed, Sep 05, 2018 at 12:06:45PM +0900, AKASHI Takahiro wrote:
On Tue, Sep 04, 2018 at 07:18:18PM +0200, Heinrich Schuchardt wrote:
On 07/23/2018 09:17 AM, AKASHI Takahiro wrote:
On Sat, Jul 21, 2018 at 06:53:16AM +0200, Heinrich Schuchardt wrote:
On 07/11/2018 11:06 AM, AKASHI Takahiro wrote:
With this patch, PL031 driver is converted to driver-model-compliant driver. In addition, CONFIG_SYS_RTC_PL031_BASE is no longer valid.
Signed-off-by: AKASHI Takahiro takahiro.akashi@linaro.org
drivers/rtc/Kconfig | 6 ++ drivers/rtc/pl031.c | 126 ++++++++++++++++++++++------------- scripts/config_whitelist.txt | 1 - 3 files changed, 86 insertions(+), 47 deletions(-)
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index a3f8c8aecc..96c4cce410 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -55,6 +55,12 @@ config RTC_MV Enable Marvell RTC driver. This driver supports the rtc that is present on some Marvell SoCs.
+config RTC_PL031
- bool "Enable ARM PL031 driver"
- depends on DM_RTC
- help
Enable ARM PL031 driver.Tom merged http://git.denx.de/?p=u-boot.git;a=commit;h=b19886b9469174213877ef37670ce35c... https://patchwork.ozlabs.org/patch/936533/ ARM: qemu-arm: enable RTC which is superseeded by your patch series.
We should avoid duplicate entries CONFIG_RTC_PL031.
Symbol CONFIG_SYS_RTC_PL031_BASE can be removed in include/configs/qemu-arm.h with this patch.
Could you, please, respin your patch series.
The patch series needs rework as described above (duplicate entries CONFIG_RTC_PL031).
Best regards
Heinrich
Thank you for this reminder. While it's nothing much for me to respin my patch, I wonder how maintainers handle coming patches in ML. I submitted my first counterpart patch just a few days after your post in a form of a *reply* to your e-mail. Then your patch was merged and mine was just ignored.
I think https://www.denx.de/wiki/U-Boot/ReleaseCycle is somewhat informative here. We're about a week away from the next release so I am taking some things like typo fixes and documentation updates (and I'm weighing the i.mx PR). But new features aren't going in right now. After the window, big things that are ready can come in, things like this for example. I am hopeful that the various FAT stuff you've been working on can at least be partially brought in. Hope this helps!