On 1/4/23 01:47, Ilias Apalodimas wrote:
Hi Eddie, Thanks for the patch
Looking at the patch there's a lot of code duplication with lib/efi_loader/efi_tcg2.c. Any reason why we aren't reusing that ?
Hi,
Well the EFI code can't be used directly without configuring to include the EFI subsystem and exporting a bunch of those functions in a header file somewhere, so I added the functions in the generic tpm librrary. Now it's a matter of doing the work to use the generic functions in the EFI system. I can do that in this series if necesssary, I just haven't gotten to it.
Thanks,
Eddie
Regards /Ilias
On Tue, 3 Jan 2023 at 22:42, Eddie James eajames@linux.ibm.com wrote:
This series adds support for measuring the boot images more generically than the existing EFI support. The series includes optional measurement from the bootm command. Eventually the EFI code could be refactored to use the generic functions.
Eddie James (3): tpm: Fix spelling for tpmu_ha union tpm: Support boot measurements bootm: Support boot measurement
boot/bootm.c | 53 ++++ cmd/bootm.c | 2 + common/Kconfig | 6 + include/efi_tcg2.h | 44 --- include/image.h | 1 + include/tpm-v2.h | 139 ++++++++- lib/tpm-v2.c | 700 +++++++++++++++++++++++++++++++++++++++++++++ 7 files changed, 899 insertions(+), 46 deletions(-)
-- 2.31.1