On 15/06/2022 02:25, Peng Fan wrote:
Subject: Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS)
On 13/06/2022 05:34, Peng Fan (OSS) wrote:
在 2022/6/11 20:44, Alper Nebi Yasak 写道:
CONFIG_IS_ENABLED(BINMAN) doesn't work, but
IS_ENABLED(CONFIG_BINMAN)
worked for me. I see all 8 symbols in spl/u-boot-spl.sym. I can send you a git branch if you want?
But now with your suggestion, that means all i.MX8M boards should use the i.MX binman symbols, that is not expected. The i.MX driver code is expected to support w/o i.MX binman symbols.
In my series I'll add a macro like BINMAN_SYMS_OK that is true if binman wrote the declared symbols, and false if it didn't. Then you can check 'if (BINMAN_SYMS_OK)' to decide if the driver should use the symbols. It'll take a day or two for me to test and send. If the macro isn't good enough, maybe you can add a new config for the driver's binman symbols.
Thanks for helping, please also share me a git repo.
I've sent a v2 for my series [1], and pushed a branch to my repo [2] with your changes added on top of mine.
[1] spl: binman: Fixes for BINMAN_SYMBOLS https://lore.kernel.org/u-boot/20220618121316.12061-1-alpernebiyasak@gmail.c...
[2] alpernebbi/u-boot at imx-ddr-binman-symbols https://github.com/alpernebbi/u-boot/tree/imx-ddr-binman-symbols
(Is there any i.MX8M board that won't have working symbols for ddr_fw files after this series?)
I think NO, but I still prefer symbols could be disabled on demand, some NXP downstream validation boards not have symbols enabled.
Thanks, Peng.