Hi Wolfgang,
2011/10/11 Wolfgang Denk wd@denx.de:
Dear =?UTF-8?B?6aas5YWL5rOh?=,
In message CACCg+XMDNyxa5-rAdvj=oG8yhmFAkiD8OZzhZE+-ThFXcT6sfQ@mail.gmail.com you wrote:
I think volatiles which like the following should be necessary according to the 4 exceptions listed in the document "Documentation/volatile-considered-harmful.txt".
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #124: FILE: arch/nds32/include/asm/bitops.h:31: +extern void set_bit(int nr, volatile void *addr);
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #126: FILE: arch/nds32/include/asm/bitops.h:33: +static inline void __set_bit(int nr, volatile void *addr)
If you look at the implementations of these functions, they need explicit casts to actually get rid of the "volatile" attribute. So why would there be any need to pass it in the first place?
[deleted]
Understood, will fix them in the next series of patches. Thanks.