Re: [PATCH resend 1/2] gpio: mpc8xxx: don't modify gpdat when setting gpio as input

On Tue, Jan 28, 2020 at 12:04:33PM +0000, Rasmus Villemoes wrote:

Since some chips don't support reading back the value of output gpios from the gpdat register, we should not do a RMW cycle (i.e., the clrbits_be32) on the gpdat register when setting a gpio as input, as that might accidentally change the value of some other (still configured as output) gpio.

The extra indirection through mpc8xxx_gpio_set_in() does not help readability, so just fold the gpdir update into mpc8xxx_gpio_direction_input().

Signed-off-by: Rasmus Villemoes rasmus.villemoes@prevas.dk

Applied to u-boot/master, thanks!