Re: [U-Boot] [PATCH 06/11] actuax/B2: fix coding style

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message 1235542278-21451-6-git-send-email-plagnioj@jcrosoft.com you wrote:

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com

there is no Coding Style specification for loader scripts - at least I am not aware of one.

• . = ALIGN (4);
• .text : {

• cpu/ixp/start.o(.text)
  

• lib_generic/string.o(.text)
  

• lib_generic/vsprintf.o(.text)
  

• lib_arm/board.o(.text)
  

• common/dlmalloc.o(.text)
  

• cpu/ixp/cpu.o(.text)
  

• . = ALIGN(4);
• .text :
• {

If we assime C rules, then this change is to the worse.

...

• . = ALIGN (4);
• .rodata : {

• *(.rodata)
  

• }
• . = ALIGN (4);
• .data : {

• *(.data)
  

• }
• . = ALIGN (4);
• .got : {

• *(.got)
  

• }
• . =.;
• __u_boot_cmd_start =.;
• .u_boot_cmd : {

• *(.u_boot_cmd)
  

• }
• __u_boot_cmd_end =.;

• . = ALIGN(4);
• .rodata : { *(.rodata) }

• . = ALIGN (4);
• __bss_start =.;
• .bss (NOLOAD): {

• *(.bss)
  

• . = ALIGN(4);
  

• }
• _end =.;

• . = ALIGN(4);
• .data : { *(.data) }
• . = ALIGN(4);
• .got : { *(.got) }
• . = .;

You are making the code just harder to read, and more difficult to maintain as adding new lines will now be harder than it was before.

The whole change does not improve anything.

NAK.

Best regards,

Wolfgang Denk