On Monday 13 July 2009 15:45:05 Felix Radensky wrote:
The bootstrap.c file is the same as for Canyonlands. Maybe it makes sense to share it between all 460EX boards, by moving it to some common location. Stefan, what do you think ?
I'm not so sure here. Even if those settings might work on most 460EX/GT boards, some custom boards might need different PLL configurations (e.g. different EBC frequency). So it's really more board specific stuff than platform specific and we would end up with multiple "#ifdef's" in this file.
Perhaps it would be doable to extract the board specific stuff into some board file and use common code for the real command and I2C-EEPROM handling. We could move these declarations into the board specific file:
+static char *config_labels[] = { ... +};
+static u8 boot_configs[][17] = { ...
And the rest into a common file. What do you think? Dirk, are you willing to work on this?
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================