
Dear Detlev Zundel,
In message m27hw8cozk.fsf@ohwell.denx.de you wrote:
+#define CONFIG_MPC5xxx 1 /* This is an MPC5xxx CPU */ +#define CONFIG_MPC5200 1 /* (more precisely an MPC5200 CPU) */
+#define CONFIG_SYS_MPC5XXX_CLKIN 33000000 /* ... running at 33.000000MHz */
Are you sure that this is a good choice to put in a manufacturer common header file? Isn't the probability of this becoming incorrect nearly 100% for the next board from this manufacturer?
I'd advise to keep CPU stuff in the individual board config files - maybe, if you really want, create a "manroland-mpc52xx-common.h". The rest of the common configs should be re-evaluated in the same spirit.
And right you are. Thanks for pointing out.
Heiko, please rework. I haven't pushed the repo out yet, so I just remove that commit again.
Best regards,
Wolfgang Denk