5 Dec
2011
5 Dec
'11
4:19 p.m.
On 12/05/2011 03:58 AM, Christian Riesch wrote:
[snip]
include/configs/da850evm.h | 87 +++++++++++++++++++++++++++++++++
[snip]
+#define CONFIG_SYS_DA850_DDR2_SDTIMR2 ( \
- (7 << DV_DDR_SDTMR2_RASMAX_SHIFT) | \
- (0 << DV_DDR_SDTMR2_XP_SHIFT) | \
- (0 << DV_DDR_SDTMR2_ODT_SHIFT) | \
- (17 << DV_DDR_SDTMR2_XSNR_SHIFT) | \
- (199 << DV_DDR_SDTMR2_XSRD_SHIFT) | \
- (0 << DV_DDR_SDTMR2_RTP_SHIFT) | \
- (0 << DV_DDR_SDTMR2_CKE_SHIFT))
Last time I guess I wasn't clear enough, sorry, there's 0 shifts other places I disagree with two. I really think in some cases we're best off just saying "Please look at the ... section of the TRM for this part for an explanation of all bit fields." and not calculate or'ing in 0 here or there.
--
Tom