Hello Simon,
On 11/06/2015 04:15 AM, Simon Glass wrote:
Hi Przemyslaw,
On 29 October 2015 at 07:58, Przemyslaw Marczak p.marczak@samsung.com wrote:
Hi Simon,
On 10/28/2015 07:50 PM, Simon Glass wrote:
On 27 October 2015 at 06:08, Przemyslaw Marczak p.marczak@samsung.com wrote:
This commit adds common ADC node, which is disabled as default.
Signed-off-by: Przemyslaw Marczak p.marczak@samsung.com Cc: Minkyu Kang mk7.kang@samsung.com Cc: Simon Glass sjg@chromium.org
Changes V2:
- new commit
Reviewed-by: Simon Glass sjg@chromium.org
This does not look like a new commit.
This is V3, and the commit was new in V2. I didn't edit commit message if no changes made in V3.
arch/arm/dts/exynos54xx.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/arch/arm/dts/exynos54xx.dtsi b/arch/arm/dts/exynos54xx.dtsi index bd3619d..daa6a33 100644 --- a/arch/arm/dts/exynos54xx.dtsi +++ b/arch/arm/dts/exynos54xx.dtsi @@ -42,6 +42,13 @@ xhci1 = "/xhci@12400000"; };
adc@12D10000 {compatible = "samsung,exynos-adc-v2";reg = <0x12D10000 0x100>;interrupts = <0 106 0>;status = "disabled";};i2c@12CA0000 { #address-cells = <1>; #size-cells = <0>;-- 1.9.1
Thank you for review. Are you going to review the rest of patches (11-14)?
I just took a look now and made a few comments.
Regards, Simon
Thank you for the review again, but this patchset was applied to u-boot-samsung four days ago and yesterday the pull request was send. Now I can see that, it's merged to master.
Your comments are cosmetic only, so I can send the cleanup as a separated patch set.
Best regards,