Re: [U-Boot] [PATCH 2 00/22] DM: Cmd: GPIO/LED/STM32/CLK: provide command-line support for device-tree configured gpios and leds

28 Jul 2016


      Hi Vikas,
I was an holiday and am still catching up. Apart from that I'm still
working on this patchset and integrating the comments and API-changes.
What I'm currently missing is to setup the frequencies directly from
clk_stm32.c. When this is done, I'll send an update.
regards
Benjamin
On Thu, Jul 21, 2016 at 12:32:22AM +0200, Vikas MANOCHA wrote:
...
Hi Benjamin,
Please let us know if you are working on this patchset.
I just saw another patchset but not using device tree & clock framework but would like to have DT and clock framework in place for stm32.
Cheers,
Vikas
...
-----Original Message-----
From: Vikas MANOCHA
Sent: Friday, July 01, 2016 4:35 PM
To: 'Benjamin Tietz' uboot@dresden.micronet24.de; u-
boot@lists.denx.de
Subject: RE: [U-Boot] [PATCH 2 00/22] DM: Cmd: GPIO/LED/STM32/CLK:
provide command-line support for device-tree configured gpios and leds
Hi Benjamin,
Please keep all the involved developers in the "To" of the e-mail & resend
the patchset for review comments (checkout scripts/get_maintainer.pl).
Also separate the generic stuff (dts/led) from platform specific in another
patchset.
Cheers,
Vikas
...
-----Original Message-----
From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of
Benjamin Tietz
Sent: Monday, June 20, 2016 11:26 AM
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2 00/22] DM: Cmd: GPIO/LED/STM32/CLK:
provide
...
command-line support for device-tree configured gpios and leds
This series begins to provide device-tree support on stm32 devices,
starting with a the stack of a simple clock-driver (at least
enabling/disabling peripheral clocks), the gpio driver and leds.
As the current led command-line interface isn't aware of any
device-tree configured led, the command gets rewritten and extended
for device-tree LEDs on the way. These changes are architecture
indipendent.
...
To accomplish these changes the led-uclass driver had to be extended, too.
Changes in v2:

more verbose commit messages
correct clock calculation in stm32_clk
minor adjustments


Benjamin Tietz (22):
      stm32: gpio: fix otype access
      stm32: gpio_direction_output: make sure, output is set to push-pull
      stm32: gpio_get_value: always return 0 or 1
      stm32f429-discovery: config: enable status leds
      Cmd: led: provide a selector in kconfig
      DTS: stm32f429: provide device-tree files (from linux kernel)
      clock-uclass: allow disabling a peripheral clock
      STM32: clock: provide dts-accessible clock driver
      DTS: STM32f429: add gpio-banks
      STM32: gpio: group SOC-specific code to one ifdef/elif construct
      GPIO: STM32: make DTS-aware
      STM32F429-discovery: led: disable board-specific code, if DM is
selected
...
  GPIO/LED: make more robust, if STATUS_LED isn't selected
  Cmd: LED: rewrite to prepare non-static access
  DTS: STM32F429-disco: add board leds and enable rcc
  LED: add function to retrieve a device's label
  LED: provide function to count and get all (DM-)LEDs
  cmd: LED: be aware of DTS-configured leds
  LED: provide functionality to get led status
  LED: GPIO: provide get_on() op
  LED: provide toggling interface
  Cmd: LED: make DM-leds toggle


arch/arm/dts/Makefile                 |    2
 arch/arm/dts/armv7-m.dtsi             |   24 ++
 arch/arm/dts/stm32429i-eval.dts       |   75 ++++++
 arch/arm/dts/stm32f429-disco.dts      |   97 ++++++++
 arch/arm/dts/stm32f429.dtsi           |  282 +++++++++++++++++++++++
 board/st/stm32f429-discovery/Makefile |    3
 cmd/Kconfig                           |    4
 cmd/led.c                             |  401 ++++++++++++++++++++++++---------
 drivers/clk/Kconfig                   |    4
 drivers/clk/Makefile                  |    1
 drivers/clk/clk-uclass.c              |   10 +
 drivers/clk/clk_stm32.c               |  112 +++++++++
 drivers/gpio/stm32_gpio.c             |  202 ++++++++++++++---
 drivers/led/led-uclass.c              |   83 +++++++
 drivers/led/led_gpio.c                |   11 +
 drivers/misc/gpio_led.c               |    4
 drivers/misc/status_led.c             |    2
 include/clk.h                         |   18 +
 include/configs/stm32f429-discovery.h |   14 +
 include/led.h                         |   65 +++++
 include/status_led.h                  |    4
 21 files changed, 1277 insertions(+), 141 deletions(-)  create mode
100644 arch/arm/dts/armv7-m.dtsi  create mode 100644
arch/arm/dts/stm32429i- eval.dts  create mode 100644
arch/arm/dts/stm32f429-disco.dts  create mode 100644
arch/arm/dts/stm32f429.dtsi  create mode 100644
drivers/clk/clk_stm32.c
--
best regards
Benjamin Tietz
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot