18 Aug
2012
18 Aug
'12
1:24 a.m.
Dear Łukasz Dałek,
[...]
You don't need this.
Why? GCC on ARM doesn't align structures?
Align to what ? 4 bytes in uboot, so no need for __packed.
+#define UDCCFR_AREN (1<< 7) /* ACK response enable (now) */ +#define UDCCFR_ACM (1<< 2) /* ACK control mode (wait for
AREN) */
+/* latest pxa255 errata define new "must be one" bits in UDCCFR */ +#define UDCCFR_MB1 (0xff& ~(UDCCFR_AREN | UDCCFR_ACM))
What errata and where? Please document it in the comment. Also, is the register only 8 bit wide?
Ok, I will document. All registers are 32 bits wide. But some you have to access like they are 8 bits wide.
Ouch :-(
Łukasz Dałek
Best regards, Marek Vasut