Dear Joe Hershberger,
In message 1345237121-20594-1-git-send-email-joe.hershberger@ni.com you wrote:
This command allows you to read the value of a memory address and store it in an environment variable.
Signed-off-by: Joe Hershberger joe.hershberger@ni.com
common/cmd_mem.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+)
This seems redundant to me.
We already have similar functionality in the "setexpr" command.
Instead of your "mg var $addr" you can do "setexpr var $addr | 0" today. I do agree that this looks a bit circuitous and suggest to change the "setexpr" such that in addition to the regular
setexpr [.b, .w, .l] name value1 <op> value2
syntax it will also accept
setexpr [.b, .w, .l] name value1
in which case it would set the variable "name" to the value of "value1".
What do you think?
Best regards,
Wolfgang Denk