
1 Jul
2007
1 Jul
'07
5:55 p.m.
Dear Wilson,
in message 04AE3AAD-E24E-4EAE-AA2B-5B7CFA0CA026@savantav.com you wrote:
Attached is a patch that fixes a problem i saw with a coldfire 5235 port. i'll include the patch here in the email as well since it describes the problem:
First, a formal issue: you missed to include the Signed-off-by: line which is mandatory for each patch.
Second, a technical issue:
* Cannot remove eth_init() call because linux driver assumes this
* happened, for MAC Address to be loaded into microcontroller
This is a problem with the Linux driver then, and should be fixed in Linux. Please see the FAQ entry about this, and then let's get rid of this eth_init call in U-Boot. Philosophy here is that devices shall be only initialized when really used by U-Boot.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"Nature is very un-American. Nature never hurries."
- William George Jordan