Re: [U-Boot-Users] [PATCH] MPC5xxx: fix some compiler warnings in USB code

In message 20070821102751.5636.68943.stgit@tq-sewsrv-4.tq-net.de you wrote:

Fix the following warnings:

• usb.c:xx: warning: function declaration isn't a prototype
• usb_ohci.c:xxx: warning: passing argument 1 of '__fswab32' makes integer from pointer wihtout a cast

Signed-off-by: Martin Krause martin.krase@tqs.de

Applied, thanks.

Some remarks:

The patch fixes the compiler warnings, but I'm not sure, if the original code is correct. It seems, that in function periodic_unlink() the pointer ed_p is little/big endian swapped and not the content, the pointer is pointing to. Not sure if this was intended. Maybe some USB expert (Markus?) could take a look at this?

Markus, I accepted this patch to get rid of the warnings for the 2.3.0-rc1 version. Could you please check the code again it if needs to be changed as Martin suggests?

Best regards,

Wolfgang Denk