Dear Jason Cooper,
Marek,
On Fri, Jun 08, 2012 at 07:31:45PM +0200, Marek Vasut wrote:
So, I cleaned up the ext2 filesystem code a bit. I tried to separate the changes to increase the reviewability.
Marek Vasut (8): EXT2: Indent cleanup of dev.c EXT2: Indent cleanup ext2fs.c EXT2: Rework ext2fs_blockgroup() function EXT2: Rework ext2fs_read_file() EXT2: Rework ext2fs_read_symlink() EXT2: Rework ext2fs_find_file1() EXT2: Rework ext2fs_iterate_dir() EXT2: Rework ext2fs_read_block()
fs/ext2/dev.c | 74 +++--- fs/ext2/ext2fs.c | 775 +++++++++++++++++++++++++++--------------------------- 2 files changed, 416 insertions(+), 433 deletions(-)
Shall I rebase my ext2load speedup patch[1] against this? Or, wait for this to be merged?
Your patch looks great and I'm fine either way. Will these patches interfere with your patch too much? Can you help reviewing these please? I'd like the ext2 code to get cleaner as it's a real mess now :-(
Wolfgang, which way do you prefer?
thx,
Jason.
[1] http://www.mail-archive.com/u-boot@lists.denx.de/msg84977.html
Best regards, Marek Vasut