Re: [U-Boot] [PATCH 4/5] mtd/nand: Add ONFI support for FSL NAND controller

On 12/08/2011 04:49 AM, Shengzhou Liu wrote:

• fix NAND_CMD_READID command for ONFI detect.
• add NAND_CMD_PARAM command to read the ONFI parameter page.

Signed-off-by: Shengzhou Liu Shengzhou.Liu@freescale.com

drivers/mtd/nand/fsl_elbc_nand.c | 19 ++++++++++++------- 1 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c index 4d1e527..52362b1 100644 --- a/drivers/mtd/nand/fsl_elbc_nand.c +++ b/drivers/mtd/nand/fsl_elbc_nand.c @@ -340,20 +340,25 @@ static void fsl_elbc_cmdfunc(struct mtd_info *mtd, unsigned int command,

/* READID must read all 5 possible bytes while CEB is active */ case NAND_CMD_READID:

• vdbg("fsl_elbc_cmdfunc: NAND_CMD_READID.\n");
  

• case NAND_CMD_PARAM:

• vdbg("fsl_elbc_cmdfunc: NAND_CMD 0x%x.\n", command);
  
  

  out_be32(&lbc->fir, (FIR_OP_CW0 << FIR_OP0_SHIFT) | (FIR_OP_UA << FIR_OP1_SHIFT) | (FIR_OP_RBW << FIR_OP2_SHIFT));

• out_be32(&lbc->fcr, NAND_CMD_READID << FCR_CMD0_SHIFT);
  

• /* 5 bytes for manuf, device and exts */
  

• out_be32(&lbc->fbcr, 5);
  

• ctrl->read_bytes = 5;
  

• out_be32(&lbc->fcr, command << FCR_CMD0_SHIFT);
  

• /*
  

•  * although currently it's 8 bytes for READID, we always read
  

•  * the maximum 256 bytes(for PARAM)
  

•  */
  

• out_be32(&lbc->fbcr, 256);
  

• ctrl->read_bytes = 256;
  

  ctrl->use_mdr = 1;

• ctrl->mdr = 0;
  

• ctrl->mdr = column;
  

  set_addr(mtd, 0, 0, 0); fsl_elbc_run_command(mtd);

• if (mtd->writesize > 2048)
  

• 	memcpy_fromio(ctrl->buffer, ctrl->addr, 256);
  

This memcpy_fromio looks like leakage from patch 5/5.

-Scott