On Mon, Jun 30, 2014 at 02:32:20PM -0700, Stephen Warren wrote:
On 06/30/2014 02:53 PM, Allen Martin wrote:
Norrin (PM370) is a Tegra124 clamshell board that is very similar to venice2, but it has a different panel, the sdcard cd sense is flipped, and it has a different revision of the AS3722 PMIC. Reuse the venice2 config with a norrin dtb. This board is also refered to as "nyan" in the ChromeOS trees.
Isn't the pinmux different too? I think this patch should contain board/nvidia/norrin/pinmux-config-norrin.h shouldn't it? That in turn would mean adding Norrin support to tegra-pinmux-scripts. Of course, if they really do have 100% identical pinmux, then there's no issue. I'm skeptical though.
AFAIK they really do have identical pinmux, I'll double check the pinmux spreadsheet to make sure.
There's another unintended side effect of reusing the venice2 board this way that I discovered after posting this. It causes CONFIG_SYS_BOARD to be set to venice2 still, which causes the "board_name" environment variable to be set to venice2, which causes boot.scr to look for a venice2 dtb.
It may be cleaner to make norrin a proper board, and just have it #include the vencie2 pinmux.
-Allen
nvpublic