15 Mar
2013
15 Mar
'13
10:13 p.m.
On Fri, Mar 15, 2013 at 04:58:17PM -0400, Matt Porter wrote:
[snip]
- /* Ethernet */
- writel(PRCM_MOD_EN, &cmalwon->l3slowclkstctrl);
- while ((readl(&cmalwon->l3slowclkstctrl) & 0x2100) != 0x2100)
;- writel(PRCM_MOD_EN, &cmalwon->ethclkstctrl);
- writel(PRCM_MOD_EN, &cmalwon->ethernet0clkctrl);
- while ((readl(&cmalwon->ethernet0clkctrl) & 0x30000) != 0)
;- writel(PRCM_MOD_EN, &cmalwon->ethernet1clkctrl);
- while ((readl(&cmalwon->ethernet1clkctrl) & 0x30000) != 0)
Please define away the magic numbers.
[snip]
+void sata_pll_config(void) +{
- /* TRM 21.3.1 */
- writel(0xc12c003c, &spll->pllcfg1);
I'm OK with comments, but please make it a multi-line thing that explains what's going on so that it's clear that yes, really, we shouldn't have defined these.
--
Tom