Heinrich,
On Tue, Oct 09, 2018 at 07:19:58PM +0200, Heinrich Schuchardt wrote:
On 10/09/2018 09:24 AM, AKASHI, Takahiro wrote:
Do you have any specific idea about what is really missing in Leif's/Rob's HII patch? (My original question.)
-Takahiro Akashi
Please, see https://patchwork.ozlabs.org/patch/823807/
Thanks, I didn't notice this thread.
Open topics were:
- usage of bitfields
- incorrect determination of string lengths
- too deep nesting of of loops and ifs
Okay, those seem to be easily fixable at a glance.
- incomplete implementation of the protocols
That is a matter I'm concerned about. There's no consensus yet about what should be in an "initial" port.
BTW, you said there were some missing protocols to run i386 version of Shell: EFI HII font protocol and EFI HII Image protocol. Do you still believe so even after Alex's comment?
Thanks, -Takahiro Akashi
As other protocols are based on the HII database protocol we should start with this protocol in a separate patch. We should have a unit test in lib/efi_selftest/ for all methods of the protocol.
Best regards
Heinrich