----- Forwarded message from scan-admin@coverity.com -----
Date: Tue, 25 May 2021 01:05:20 +0000 (UTC) From: scan-admin@coverity.com To: tom.rini@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot
Hi,
Please find the latest report on new defect(s) introduced to Das U-Boot found with Coverity Scan.
3 new defect(s) introduced to Das U-Boot found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s)
** CID 331856: Uninitialized variables (UNINIT)
________________________________________________________________________________________________________ *** CID 331856: Uninitialized variables (UNINIT) /lib/efi_loader/efi_tcg2.c: 921 in create_specid_event() 915 spec_event->spec_version_major = 916 TCG_EFI_SPEC_ID_EVENT_SPEC_VERSION_MAJOR_TPM2; 917 spec_event->spec_errata = 918 TCG_EFI_SPEC_ID_EVENT_SPEC_VERSION_ERRATA_TPM2; 919 spec_event->uintn_size = sizeof(efi_uintn_t) / sizeof(u32); 920
CID 331856: Uninitialized variables (UNINIT) Using uninitialized value "supported" when calling "tpm2_get_pcr_info".
921 err = tpm2_get_pcr_info(dev, &supported, &active, 922 &spec_event->number_of_algorithms); 923 if (err) 924 goto out; 925 if (spec_event->number_of_algorithms > MAX_HASH_COUNT || 926 spec_event->number_of_algorithms < 1)
** CID 331855: Uninitialized variables (UNINIT)
________________________________________________________________________________________________________ *** CID 331855: Uninitialized variables (UNINIT) /lib/efi_loader/efi_tcg2.c: 921 in create_specid_event() 915 spec_event->spec_version_major = 916 TCG_EFI_SPEC_ID_EVENT_SPEC_VERSION_MAJOR_TPM2; 917 spec_event->spec_errata = 918 TCG_EFI_SPEC_ID_EVENT_SPEC_VERSION_ERRATA_TPM2; 919 spec_event->uintn_size = sizeof(efi_uintn_t) / sizeof(u32); 920
CID 331855: Uninitialized variables (UNINIT) Using uninitialized value "active" when calling "tpm2_get_pcr_info".
921 err = tpm2_get_pcr_info(dev, &supported, &active, 922 &spec_event->number_of_algorithms); 923 if (err) 924 goto out; 925 if (spec_event->number_of_algorithms > MAX_HASH_COUNT || 926 spec_event->number_of_algorithms < 1)
** CID 331854: Control flow issues (NO_EFFECT) /lib/efi_loader/efi_tcg2.c: 752 in efi_tcg2_hash_log_extend_event()
________________________________________________________________________________________________________ *** CID 331854: Control flow issues (NO_EFFECT) /lib/efi_loader/efi_tcg2.c: 752 in efi_tcg2_hash_log_extend_event() 746 if (efi_tcg_event->size < efi_tcg_event->header.header_size + 747 sizeof(u32)) { 748 ret = EFI_INVALID_PARAMETER; 749 goto out; 750 } 751
CID 331854: Control flow issues (NO_EFFECT) This less-than-zero comparison of an unsigned value is never true. "efi_tcg_event->header.pcr_index < 0U".
752 if (efi_tcg_event->header.pcr_index < 0 || 753 efi_tcg_event->header.pcr_index > TPM2_MAX_PCRS) { 754 ret = EFI_INVALID_PARAMETER; 755 goto out; 756 } 757
________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0...
To manage Coverity Scan email notifications for "tom.rini@gmail.com", click https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0...
----- End forwarded message -----