Re: [PATCH 2/2] pmic: pca9450: drop pointless .data entries

On 5/3/22 17:58, Rasmus Villemoes wrote:

These are the i2c addresses of the chips, but that comes from device tree. Having that information duplicated here just adds confusion.

Signed-off-by: Rasmus Villemoes rasmus.villemoes@prevas.dk

Reviewed-by: Jaehoon Chung jh80.chung@samsung.com

Best Regards, Jaehoon Chung

---

drivers/power/pmic/pca9450.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/power/pmic/pca9450.c b/drivers/power/pmic/pca9450.c index 2394b196c5..34cee34dba 100644 --- a/drivers/power/pmic/pca9450.c +++ b/drivers/power/pmic/pca9450.c @@ -81,9 +81,9 @@ static struct dm_pmic_ops pca9450_ops = { };

static const struct udevice_id pca9450_ids[] = {

• { .compatible = "nxp,pca9450a", .data = 0x25, },
• { .compatible = "nxp,pca9450b", .data = 0x25, },
• { .compatible = "nxp,pca9450c", .data = 0x25, },

• { .compatible = "nxp,pca9450a" },
• { .compatible = "nxp,pca9450b" },
• { .compatible = "nxp,pca9450c" }, { }

};