On Wed, Nov 01, 2023 at 10:20:41AM +0000, Abdellatif El Khlifi wrote:
Hi Tom,
On Thu, Oct 26, 2023 at 01:50:49PM +0100, abdellatif.elkhlifi@arm.com wrote:
From: Abdellatif El Khlifi abdellatif.elkhlifi@arm.com
unzip the kernel before executing it
The Corstone-1000 kernel has become too large to fit in the available storage. Switching to a compressed kernel avoids the problem, but requires uncompressing it.
Changes made are generated using savedefconfig.
Signed-off-by: Abdellatif El Khlifi abdellatif.elkhlifi@arm.com Signed-off-by: Jon Mason jon.mason@arm.com Signed-off-by: Rui Miguel Silva rui.silva@linaro.org
configs/corstone1000_defconfig | 1551 +++++++++++++++++++++++++++++++- 1 file changed, 1550 insertions(+), 1 deletion(-)
diff --git a/configs/corstone1000_defconfig b/configs/corstone1000_defconfig index 3b5733b777..f25da79ec8 100644 --- a/configs/corstone1000_defconfig +++ b/configs/corstone1000_defconfig @@ -1,69 +1,1618 @@
This wasn't done as savedefconfig, so I had to do a tiny bit of reworking to re-save it and then again on 3/3 for it to apply. In the future please make sure defconfig changes really are savedefconfig'd, thanks and applied to u-boot/master.
Sorry for the extra work done.
However, I already followed these steps to generate the defconfig. The steps below show that generating the defconfig at the current commit level generates a .config identical to corstone1000_defconfig. I used the HEAD of next. Please, am I missing something here ?
More details:
b055167ef05898075dc2b2fa3ea244f56932c75e (HEAD) corstone1000: add compressed kernel support e29b932aa07fa0226d325b35d96cd4eea0370129 (origin/next) Merge branch '2023-09-30-Kconfig-updates' into next
$ make corstone1000_defconfig savedefconfig HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o YACC scripts/kconfig/zconf.tab.c LEX scripts/kconfig/zconf.lex.c HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf # # configuration written to .config # scripts/kconfig/conf --savedefconfig=defconfig Kconfig $ diff -pruN configs/corstone1000_defconfig .config
Uh, that's not what I see, nor is it what was in your patch. The patch turned configs/corstone1000_defconfig in to the 1600 line .config file. And the step you're missing is "mv defconfig configs/corstone1000_defconfig" after doing savedefconfig.