Re: [U-Boot] [PATCH] video: cfb_console: fix definition and usage of CURSOR_xxx macros

Hi Timur,

The CURSOR_ON, CURSOR_OFF, and CURSOR_SET macros are defined incorrectly. If cursor support is disabled, then these macros are defined to nothing, but then they are used like this:

if (console_col < CONSOLE_COLS) CURSOR_OFF console_row++;

which was compiled like this:

if (console_col < CONSOLE_COLS) console_row++;

This is obviously not what was intended.

Signed-off-by: Timur Tabi timur@freescale.com

Patch looks good, thanks!

Acked-by: Detlev Zundel dzu@denx.de

---

This patch depends on

video: cfb_console: add support for 4bpp bitmaps with GDF_32BIT_X888RGB

drivers/video/cfb_console.c | 24 ++++++++++++++---------- 1 files changed, 14 insertions(+), 10 deletions(-)