Hi Kim,
On Thu, Nov 3, 2011 at 3:48 PM, Kim Phillips kim.phillips@freescale.com wrote:
On Tue, 11 Oct 2011 21:46:05 -0500 Joe Hershberger joe.hershberger@ni.com wrote:
Some core ipic code from Linux - commit bbf25010f1a6b761914430f5fca081ec8c7accd1
commit bbf25010f1a6b761914430f5fca081ec8c7accd1 Author: Linus Torvalds torvalds@woody.linux-foundation.org Date: Tue Oct 9 13:31:38 2007 -0700
Linux 2.6.23
...any particular reason to pull in such an old version?
That was the current version when I implemented the interrupt support.
diff --git a/arch/powerpc/include/asm/mpc83xx_irq.h b/arch/powerpc/include/asm/mpc83xx_irq.h new file mode 100644 index 0000000..fc77134 --- /dev/null +++ b/arch/powerpc/include/asm/mpc83xx_irq.h @@ -0,0 +1,72 @@ +#ifndef _MPC83xx_IRQ_H +#define _MPC83xx_IRQ_H
+#define NR_IRQS 128
+/*
- Some ipic code copied from the linux 2.6 kernel:
- /arch/powerpc/sysdev/ipic.*
- /arch/powerpc/include/asm/ipic.h
- */
And why hasn't the Freescale copyright info been retained???
Oversight. Sorry.
- This list is specific to the mpc8313e for now.
it shouldn't have to be. How is this list used outside of interrupts.c?
Simply because I didn't audit every other SoC in the family to determine how to make it generic.
- */
+#define IPIC_INT_UART1 (0x09)
Is it possible to avoid the list altogether somehow? Use an embedded device tree? See doc/README.fdt-control.
Perhaps that is a good long-term approach. I'm not sure I'm up for that retrofit just now. ;)
Thanks, -Joe