On Fri, Nov 08, 2019 at 02:03:58PM -0700, Simon Glass wrote:
Hi Tom,
On Fri, 8 Nov 2019 at 14:02, Tom Rini trini@konsulko.com wrote:
On Fri, Nov 08, 2019 at 01:40:31PM -0700, Simon Glass wrote:
Hi Tom,
On Fri, 8 Nov 2019 at 12:54, Simon Glass sjg@chromium.org wrote:
This series drops the size of common.h down further, by moving things out into existing and new header files.
It is now down to about 200 lines.
Changes in v2:
- Move trap_init() into init.h instead; update commit message
Simon Glass (41): common: Move legacy CPU functions to their own header Drop CONFIG_SHOW_ACTIVITY common: Drop global inclusion of status_led.h status_led: Tidy up the code style common: Move random-number functions into their own header common: Drop linux/crc8.h crc: Fix code style with crc functions crc32: Use the crc.h header for crc functions spl: bootcount: Move code out of header file common: Move bootcount functions to their header file common: Move sorting functions to their own header file Move strtomhz() to vsprintf.h common: Move env_get_ip() to net.h serial: usb: Correct the usbtty_...() prototypes common: Move serial_printf() to the serial header common: Move serial functions out of common.h common: Add a new lz4.h header file common: Move some time functions out of common.h common: Move wait_ticks functions out of common.h common: Move timer_get_us() function out of common.h common: Move get_ticks() function out of common.h common: Move mii_init() function out of common.h common: Move some CPU functions out of common.h common: Drop cpu_init() common: Move checkcpu() out of common.h common: Move some SMP functions out of common.h arm: powerpc: Tidy up code style for cache functions common: Move some cache and MMU functions out of common.h common: Drop checkicache() and checkdcache() common: Move ARM cache operations out of common.h arm: powerpc: Tidy up code style for interrupt functions common: Move interrupt functions into a new header common: Move enable/disable_interrupts out of common.h common: Move command functions out of common.h common: Drop board_show_dram() common: Move board_get_usable_ram_top() out of common.h common: Move some board functions out of common.h common: Move pci_init_board() out of common.h common: Move trap_init() out of common.h common: Drop get_endaddr() common: Move old EEPROM functions into a new header
I'm sorry I just noticed that this was waiting on a new rev. Only minor changes, mostly a rebase.
Thanks. I recall Daniel was a big concerned about calling some stuff "legacy" that wasn't so much legacy as "doesn't / shouldn't be DMified", was that addressed too?
I changed the patch that he commented on, so we'll see.
But I'm open to other adjustments...
OK, I'll take a harder look, thanks.