Hi Simon,
On Tue, Jul 18, 2017 at 4:02 PM, Simon Glass sjg@chromium.org wrote:
Hi Mario,
On 14 July 2017 at 05:55, Mario Six mario.six@gdsys.cc wrote:
Since the GPIO controllers on MPC8XXX just vary in the number of pins offered, the DM driver for the MPC85XX SoC can be used for the whole family.
To reflect this, we rename the mpc85xx_gpio driver to the more generic mpc8xxx_gpio, and add the needed mpc8xxx_gpio_plat structure to the mpc83xx gpio.h.
Hence, this driver now also serves as a GPIO DM-driver for the MPC83XX platform.
Signed-off-by: Mario Six mario.six@gdsys.cc
arch/powerpc/include/asm/arch-mpc83xx/gpio.h | 8 + arch/powerpc/include/asm/arch-mpc85xx/gpio.h | 2 +- drivers/gpio/Kconfig | 9 +- drivers/gpio/Makefile | 2 +- drivers/gpio/mpc85xx_gpio.c | 253 ------------------------- drivers/gpio/mpc8xxx_gpio.c | 274 +++++++++++++++++++++++++++ 6 files changed, 287 insertions(+), 261 deletions(-) delete mode 100644 drivers/gpio/mpc85xx_gpio.c create mode 100644 drivers/gpio/mpc8xxx_gpio.c
This is hard to review as it seems you have made changes as well as renamed the fine. Can you do the rename first and then the changes in a subsequent patch?
OK, I'll split this one into two patches. If you want to take a look in the mean time, a bit of git magic helps:
git diff -C30% COMMITID~1..COMMITID
Where COMMITID is the id of the commit. This should ignore the rename and only display the actual changes.
Best regards, Mario