Re: [U-Boot] [PATCH 2/2] Implementation of a bootloader area protection during auto-update (new CONFIG_SYSTEM_START_ADDR necessary)

Dear Christoph Koenig,

In message 1301671320-16131-2-git-send-email-christoph.koenig@ikt.uni-hannover.de you wrote:

Subjecxt too long.

Commit message missing.

No explanation given what the code is supposed to do.

SoB line missing.

+#ifdef CONFIG_SYSTEM_START_ADDR

• if (addr_first < CONFIG_SYSTEM_START_ADDR) {

• printf("Error: auto-update does not allow to write a new bootloader\n");
  

• return 1;
  

• }

+#endif

Explanation and documentation for new CONFIG_ option (in README) missing.

I think this approach is too simplistic. Some boards have the boot loader at the beginning of the OR flash, some at the end, others right in the middle. Still others boot from NAND flash or SDCard.

Best regards,

Wolfgang Denk