On Fri, Apr 01, 2016 at 06:07:18PM -0500, Scott Wood wrote:
On Fri, 2016-04-01 at 08:51 -0400, Tom Rini wrote:
On Fri, Apr 01, 2016 at 04:59:44PM +0530, Mugunthan V N wrote:
Add CONFIG_NAND as a Kconfig option so that it can be selected using menuconfig or defconfig.
Signed-off-by: Mugunthan V N mugunthanvnm@ti.com
Good but you need to update configs/ to remove NAND from CONFIG_SYS_EXTRA_OPTIONS and add CONFIG_NAND=y
NACK
That CONFIG_NAND is a target-local option used by some boards to indicate boot source. It is not equivalent to CONFIG_CMD_NAND which is what enables the NAND subsystem.
Exactly! We need to have 'NAND' moved from CONFIG_SYS_EXTRA_OPTIONS and into a real Kconfig entry. That said, I think this might have forgotten to enable it in other places too but just 'NAND' needs to migrate out of where it is.