Re: [PATCH v2 2/3] efi: Correct display of table GUIDs

On Sun, 12 Nov 2023 at 22:55, Simon Glass sjg@chromium.org wrote:

The printf() %pU option decodes GUIDs so it is not necessary to do this first. Drop the incorrect code.

Signed-off-by: Simon Glass sjg@chromium.org

(no changes since v1)

cmd/efi_common.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/cmd/efi_common.c b/cmd/efi_common.c index f4056096cd3f..1aa2351fcdfd 100644 --- a/cmd/efi_common.c +++ b/cmd/efi_common.c @@ -17,10 +17,8 @@ void efi_show_tables(struct efi_system_table *systab)

    for (i = 0; i < systab->nr_tables; i++) {
            struct efi_configuration_table *tab = &systab->tables[i];

•           char guid_str[37];
  
  

•           uuid_bin_to_str(tab->guid.b, guid_str, 1);
  

•           printf("%p  %pUl  %s\n", tab->table, guid_str,
  

•           printf("%p  %pUl  %s\n", tab->table, tab->guid.b,
                   uuid_guid_get_str(tab->guid.b) ?: "(unknown)");
    }
  

}

2.42.0.869.gea05f2083d-goog

Reviewed-by: Ilias Apalodimas ilias.apalodimas@linaro.org