-----Original Message----- From: Heiko Schocher [mailto:hs@denx.de] Sent: Monday, September 05, 2011 7:01 PM To: Premi, Sanjeev Cc: Albert ARIBAUD; u-boot@lists.denx.de; Wolfgang Denk Subject: Re: [U-Boot] [PATCH] omap3: beagle: Fix build warning
Hello Sanjeev,
Premi, Sanjeev wrote:
-----Original Message----- From: Albert ARIBAUD [mailto:albert.u.boot@aribaud.net] Sent: Monday, September 05, 2011 5:06 PM To: Premi, Sanjeev Cc: u-boot@lists.denx.de; Heiko Schocher; Wolfgang Denk Subject: Re: [U-Boot] [PATCH] omap3: beagle: Fix build warning
[snip]...[snip]
--- a/include/configs/omap3_beagle.h +++ b/include/configs/omap3_beagle.h @@ -118,7 +118,7 @@ #define CONFIG_I2C_MULTI_BUS 1
/* Probe all devices */ -#define CONFIG_SYS_I2C_NOPROBES {0x0, 0x0} +#define CONFIG_SYS_I2C_NOPROBES {{0x0, 0x0}}
/* USB */ #define CONFIG_MUSB_UDC 1
Won't all board configs which use CONFIG_SYS_I2C_NOPROBES
suffer from
the same bug? I would hate to see an endless trickle of individual board config patches, and would much prefer a single patch to fix all boards
[sp] Actually, not all boards suffer from this issue. But yes, I can make a single patch and submit it in next couple of hours.
Isn;t this issue introduced just from commit
author Jason Kridner jkridner@beagleboard.org Sat, 23 Jul 2011 04:42:44 +0000 (23:42 -0500) committer Albert ARIBAUD albert.u.boot@aribaud.net Sun, 4 Sep 2011 09:36:21 +0000 (11:36 +0200) commit f74fc4ae6d6257ecdbc0049f6aa2e96212207f05
so ~1day old ... Hmm, I think, this is just a single board bugfix, as this warning only raises, if CONFIG_I2C_MULTI_BUS and CONFIG_SYS_I2C_NOPROBES is defined ... as introduced for the beagle board through above commit ... other boards should be clean, as I tend to do a MAKEALL after applying patches from ML ... but if you find
[sp] Yes, you are right about the issue, and hence I posted it as single patch against beagleboard only. The description includes a bash script that I used to "blindly" extent the fix to other boards.
I guess, MAKEALL succeeds because the appropriate config options may not be enabled for the boards.
Will dig on a few cases (of the ones changed) as to why the build succeeds.
time and can check this, it would be nice!
[sp] I only have a arm codesourcery toolchain installed. Would be able to check only ARM boards (of the 31) impacted by the updated patch.
Can do by tomorrow...
bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany