Re: [U-Boot] [PATCH v0 2/4] env: check and apply changes on delete/destroy

Dear Gerlando Falauto,

In message 1319647072-17504-3-git-send-email-gerlando.falauto@keymile.com you wrote:

Signed-off-by: Gerlando Falauto gerlando.falauto@keymile.com

common/cmd_nvedit.c | 2 +- include/search.h | 6 ++++-- lib/hashtable.c | 18 ++++++++++++------ 3 files changed, 17 insertions(+), 9 deletions(-)

Are you sure these changes are really independent from the previous and following ones? Ordo we introduc bisectability issues here?

-extern void hdestroy_r(struct hsearch_data *__htab); +extern void hdestroy_r(struct hsearch_data *__htab,

•        apply_cb apply);
  

See provious comments - indentation always by TAB. Please fix globally, i. e. in all your patches.

• 	if (apply != NULL) {
  

• 		/* deletion is always forced */
  

Um.... why is this the case?

Best regards,

Wolfgang Denk