On Dec 16, 2011, at 14:30, Mike Frysinger wrote:
On Friday 16 December 2011 13:49:15 Moffett, Kyle D wrote:
On Dec 16, 2011, at 00:05, Mike Frysinger wrote:
On Thursday 15 December 2011 22:32:41 Kyle Moffett wrote:
This new #define is set in config_cmd_defaults.h (which is automatically included on every board by "mkconfig"), but this allows boards to elect to omit the "reset" command if necessary with "#undef CONFIG_CMD_RESET".
would be a good time to split this into a dedicated common/cmd_reset.c, we can also then fix cmd_boot.c to only build when CONFIG_CMD_GO is enabled
The only references to CONFIG_CMD_GO are in config_cmd_defaults.h, README, and common/cmd_boot.c, there is nothing that ever turns it off, so perhaps the config symbol should just be removed?
i have some boards that turn it off
Ok,
I really don't see the point in moving these 5 lines to their own file, especially since they are in is already just 78 lines long: U_BOOT_CMD( reset, 1, 0, do_reset, "Perform RESET of the CPU", "" );
If you really think that's what I should do, though, I'll go ahead and make that change.
Cheers, Kyle Moffett
-- Curious about my work on the Debian powerpcspe port? I'm keeping a blog here: http://pureperl.blogspot.com/