On Wed, Feb 13, 2019 at 6:51 AM André Przywara andre.przywara@arm.com wrote:
On 09/02/2019 13:14, Jagan Teki wrote:
Add CLK support to enable AHB and MOD SPI clocks on sun4i_spi driver.
Note, that the code will enable and disable clock in claim and release calls to make proper clock and reset handling between claiming and releasing SPI bus.
Signed-off-by: Jagan Teki jagan@amarulasolutions.com
That looks alright to me, but I wonder if you should introduce the reset support here as well. Since it's optional, it shouldn't hurt to have it in already, even though the SUN4I generation doesn't need it.
OK, but I see the point of adding reset during A31 support patch since it has reset control on it and it's becoming optional since we are trying to use same driver even for A10.