Re: [U-Boot] [PATCH v1 04/18] board: gdsys: Configure DP501 SPDIF input

Hello Dirk,

Am 28.10.2015 um 11:46 schrieb dirk.eibach@gdsys.cc:

From: Dirk Eibach dirk.eibach@gdsys.cc

Signed-off-by: Dirk Eibach dirk.eibach@gdsys.cc

board/gdsys/common/dp501.c | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/board/gdsys/common/dp501.c b/board/gdsys/common/dp501.c index 7eb15ed..baace38 100644 --- a/board/gdsys/common/dp501.c +++ b/board/gdsys/common/dp501.c @@ -77,6 +77,8 @@ void dp501_powerup(u8 addr) i2c_reg_write(addr + 2, 0x24, 0x02); /* clock input single ended */ #endif

• i2c_reg_write(addr + 2, 0x1a, 0x04); /* SPDIF input method TTL */
• i2c_reg_write(addr + 2, 0x00, 0x18); /* driving strength */ i2c_reg_write(addr + 2, 0x03, 0x06); /* driving strength */ i2c_reg_write(addr, 0x2c, 0x00); /* configure N value */

Hmm... a lot of magical values ... some defines would be nice here.

Beside of this:

Reviewed-by: Heiko Schocher hs@denx.de

bye, Heiko