On 08/25/2015 12:04 AM, Simon Glass wrote: [...]
+# Please keep the configuration alphabetically sorted. +config DM_TESTPROC_SANDBOX
Should this be REMOTEPROC_SANDBOX?
Yep - will do.
diff --git a/drivers/remoteproc/sandbox_testproc.c b/drivers/remoteproc/sandbox_testproc.c new file mode 100644 index 000000000000..e942f66fc2dc --- /dev/null +++ b/drivers/remoteproc/sandbox_testproc.c @@ -0,0 +1,243 @@ +/*
- (C) Copyright 2015
- Texas Instruments Incorporated - http://www.ti.com/
- SPDX-License-Identifier: GPL-2.0+
- */
+#define pr_fmt(fmt) "%s: " fmt, __func__
^^
+#include <common.h> +#include <dm.h> +#include <errno.h> +#include <remoteproc.h>
[...]
+static int sandbox_testproc_is_running(struct udevice *dev) +{
struct dm_rproc_uclass_pdata *uc_pdata;struct sandbox_test_devdata *ddata;int ret = 1;uc_pdata = dev_get_uclass_platdata(dev);ddata = dev_get_priv(dev);if (ddata->current_state == sb_running)ret = 0;debug("%s: called(%d)\n", uc_pdata->name, ret);should that say "is_running called" / do you need __func__?
pr_fmt (at the start of the file) should take care of it.
[...]
+U_BOOT_DRIVER(sandbox_testproc) = {
/* *INDENT-OFF* */What is that for? ^^
trying to keep indent sane - will drop.
Thanks once again for the review.