On Wed, 19 Nov 2008 10:11:32 +0100 Heiko Schocher hs@denx.de wrote:
MAINTAINERS | 1 + MAKEALL | 1 + Makefile | 3 + board/keymile/kmeter1/Makefile | 51 ++++ board/keymile/kmeter1/config.mk | 24 ++ board/keymile/kmeter1/kmeter1.c | 153 ++++++++++++ include/configs/kmeter1.h | 521 +++++++++++++++++++++++++++++++++++++++ 7 files changed, 754 insertions(+), 0 deletions(-)
a doc/README.kmeter1 would be nice, esp. if the board has any h/w quirks such as with non-default dip switch settings and interactions with e.g., PIGGY.
+#define CONFIG_SYS_LOAD_ADDR 0x200000 /* default load address */
- "fileaddr=200000\0" \
I believe this and your CONFIG_SYS_LOAD_ADDR setting above are one of the same; rm the latter?
- "load=tftp ${fileaddr} ${u-boot}\0" \
- "update=protect off F0000000 F003FFFF;" \
"era F0000000 f003FFFF;" \"cp.b ${fileaddr} F0000000 ${filesize};" \"setenv filesize;saveenv\0" \
can we use something based on TEXT_BASE instead? e.g.:
"protect off " MK_STR(TEXT_BASE) " +$filesize; " \ "erase " MK_STR(TEXT_BASE) " +$filesize; " \ "cp.b $loadaddr " MK_STR(TEXT_BASE) " $filesize; " \ "protect on " MK_STR(TEXT_BASE) " +$filesize; " \ "cmp.b $loadaddr " MK_STR(TEXT_BASE) " $filesize\0" \
it'll be easier on people that modify TEXT_BASE.
other than that, looks good.
Kim