On Tue, Jan 17, 2023 at 09:39:09AM +0100 Manuel Traut wrote:
Can you test with the attached patch?
[...]
From: Manuel Traut manuel.traut@mt.com Date: Tue, 17 Jan 2023 09:30:27 +0100 Subject: [PATCH] menu: Ignore prompt variable if timeout is != 0
Since 739e8361f3fe78038251216df6096a32bc2d5839, a system with the following /boot/extlinux/extlinux.conf (which sets timeout to 50) immediately boots the first entry in the config without displaying a boot menu. According to the description, that should only happen if both prompt and timeout are set to zero in the config, but it also happens with timeout set to a non-zero value.
Reported-by: Karsten Merker merker@debian.org Signed-off-by: Manuel Traut manuel.traut@mt.com
Tested-by: Karsten Merker merker@debian.org
Hello,
many thanks for the patch. I have tested it on top of current git head and it solves the extlinux.conf menu issue: with timeout set to a non-zero value the menu gets displayed and with timeout set to zero the system immediately boots the default entry, i.e. both cases work as expected.
JFTR, here are the boot logs for both test cases:
-----8<----------8<----------8<----------8<----------8<----------8<-----
With timeout=50: ================
U-Boot 2023.01-00623-g1d3da4d31b (Jan 17 2023 - 21:17:48 +0100) [...] Hit any key to stop autoboot: 0
Device 0: QEMU VirtIO Block Device Type: Hard Disk Capacity: 102400.0 MB = 100.0 GB (209715200 x 512) ... is now current device Scanning virtio 0:1... Found /boot/extlinux/extlinux.conf Retrieving file: /boot/extlinux/extlinux.conf U-Boot menu 1: Debian GNU/Linux bookworm/sid 6.1.0-1-riscv64 2: Debian GNU/Linux bookworm/sid 6.1.0-1-riscv64 (rescue target) 3: Debian GNU/Linux bookworm/sid 6.0.0-6-riscv64 4: Debian GNU/Linux bookworm/sid 6.0.0-6-riscv64 (rescue target) 5: Debian GNU/Linux bookworm/sid 6.0.0-5-riscv64 6: Debian GNU/Linux bookworm/sid 6.0.0-5-riscv64 (rescue target) Enter choice: 1 1: Debian GNU/Linux bookworm/sid 6.1.0-1-riscv64 Retrieving file: /boot/vmlinux-6.1.0-1-riscv64 Retrieving file: /boot/initrd.img-6.1.0-1-riscv64 append: root=/dev/vda1 rw noquiet Moving Image from 0x84000000 to 0x80200000, end=815e5000 ## Flattened Device Tree blob at ff7334b0 Booting using the fdt blob at 0xff7334b0 Working FDT set to ff7334b0 Using Device Tree in place at 00000000ff7334b0, end 00000000ff737dea Working FDT set to ff7334b0
Starting kernel ...
-----8<----------8<----------8<----------8<----------8<----------8<-----
With timeout=0: ===============
U-Boot 2023.01-00623-g1d3da4d31b (Jan 17 2023 - 21:17:48 +0100) [...] Hit any key to stop autoboot: 0
Device 0: QEMU VirtIO Block Device Type: Hard Disk Capacity: 102400.0 MB = 100.0 GB (209715200 x 512) ... is now current device Scanning virtio 0:1... Found /boot/extlinux/extlinux.conf Retrieving file: /boot/extlinux/extlinux.conf 1: Debian GNU/Linux bookworm/sid 6.1.0-1-riscv64 Retrieving file: /boot/vmlinux-6.1.0-1-riscv64 Retrieving file: /boot/initrd.img-6.1.0-1-riscv64 append: root=/dev/vda1 rw noquiet Moving Image from 0x84000000 to 0x80200000, end=815e5000 ## Flattened Device Tree blob at ff7334b0 Booting using the fdt blob at 0xff7334b0 Working FDT set to ff7334b0 Using Device Tree in place at 00000000ff7334b0, end 00000000ff737dea Working FDT set to ff7334b0
Starting kernel ... -----8<----------8<----------8<----------8<----------8<----------8<-----
Regards, Karsten