Dear Matthias Fuchs,
In message 200907061123.07261.matthias.fuchs@esd.eu you wrote:
I posted a similiar patch a long time ago:
Hmm... seems it got lost in the mists of time...
It's also a little bit more powerful because is supports alignment on top/center/bottom and right/center/left on the screen.
I couldn't find the answer posting on my patch. But I think it was rejected because of some planned changes in the video subsystem.
If we can use a powerful splashimage variable, I would vote for my patch and check it on top of git.
I can understand Wolfgang's objection but please keep the amount of variables for positioning on a reasonable level. Just one for the stuff behind the address (see my proposed format) would be ok for me.
Agreed on minimizing the number of needed variables, but (last but not least in the interest of backward compatibility) I would like to keep storage address and on-screen positioning information separated.
Your patch reads:
+ When CONFIG_SPLASH_SCREEN_ALIGN is additionally defined, + it is possible to align a small splashimage on a huge + display. This option extends the splashimage variable + syntax with an x and y position suffix. Beside absolute + positioning the characters 'l' (left), 'r' (right), + 't' (top), 'b' (bottom) and 'c' (center) are supported: + + splashimage=<address>[,<xpos>[,<pos>]] + + Example: + splashimage=fff00000,c,c
I would like to see the position information handled with a separate variable, and I think the format should be changed / extended as well. If we go to the extent to allowing such positioning, then we should allow numeric coordinates as well; this kind of conflicts with your syntax where "c,c" would mean "0xC,0xC" :-)
Maybe you can extend and rebase your patch against current code?
TIA.
Best regards,
Wolfgang Denk