Hi
Attached you find a patch which enables ECC for our board. At the moment it is pretty PPC405GPr specific, as I have no other board around to test. I have also a Yosemite and a Sequoia, but they do not seem to have a correct SPD-info. I will submit a patch once I have our PPC440EPx board up and running.
For the startup I added a small hint that ECC is working:
I2C: ready DRAM: ECC 32 MB FLASH: 512 kB
Stefan Roesesr@denx.de 10.02.07 20:15:23 >>>
On Saturday 10 February 2007 10:01, Niklaus Giger wrote:
Yes, that has mostly historic reasons. So why do you have to use a board specific flash driver and not the common cfi driver?
Because I started with a board that had a board specific flash.c, which worked. And a first attempt to use the common CFI failed, as I mixed too many changes. But I will try next week to follow you suggestion.
What flash devices do you use on your board?
I have a 8 bit boot-eprom AMD AM29LV040B and 8,16 or 32 MB of CFI-Flash (one 16 bit-wide bank), e.g. Intel 28F028J3A
<..> Best regards, Niklaus
begin 666 ecc.patch M9&EF9B`M+6=I="!A+V-P=2]P<&,T>'@O<W!D7W-D<F%M+F,@8B]C<'4O<'!C M-'AX+W-P9%]S9')A;2YC"F]L9"!M;V1E(#$P,#8T-`IN97<@;6]D92`Q,#`W M-34*:6YD97@@8S(T-#4V8BXN8V$Y,C)D-`HM+2T@82]C<'4O<'!C-'AX+W-P M9%]S9')A;2YC"BLK*R!B+V-P=2]P<&,T>'@O<W!D7W-D<F%M+F,*0$`@+30R M+#8@*S0R+#<@0$`@(VEN8VQU9&4@/&-O;6UO;BYH/@H@(VEN8VQU9&4@/&%S M;2]P<F]C97-S;W(N:#X*("-I;F-L=61E(#QI,F,N:#X*("-I;F-L=61E(#QP M<&,T>'@N:#X**R-I;F-L=61E(#QA<VTO:6\N:#X*(`H@(VEF9&5F($-/3D9) M1U]34$1?14504D]-"B`*0$`@+3DX+#8@*SDY+#@@0$`@(V5L<V4*(",@9&5F M:6YE(%-01%]%4E(H>"D@9&@>R!P<FEN=&8H>"D[(')E='5R;B@P*3L@?2!W M:&EL92`H,"D*("-E;F1I9@H@"BMV;VED('!R;V=R86U?96-C("AV;VED("IB M86YK7V)A<V5?861D<BP@=6YS:6=N960@;&]N9PD@;G5M7V)Y=&5S+"!I;G0@ M8F%N:RD["BL*("-D969I;F4@<V1R86U?2%I?=&]?;G,H:&5R='HI("@Q,#`P M,#`P,#`P+RAH97)T>BDI"B`*("\J(&9U;F-T:6]N('!R;W1O='EP97,@*B* M0$`@+3,P-"PV("LS,#<L,3`@0$`@(V5N9&EF"B`)"7-D<F%M,%]E8V-C9F<@ M/2`P>&8@/#P@4T1204TP7T5#0T-&1U]32$E&5#L*(`D)96-C7V]N(#T@,3L* M(`E](&5L<V4@>PHK(VEF(&1E9FEN960H0T].1DE'7T5#0RD@)B8@9&5F:6YE M9"A$14)51RD**PD)<')I;G1F*"(E<SH@;F@14-#(&%S('-P9"`Q,3H@)60@ M("`V.B`E9"`Q-#H@)61<;B(L(%]?1E5.0U1)3TY?7RP**PD)("`@("`@(')E M861?<W!D*#$Q*2P@<F5A9%]S<&0H-BDL(')E861?<W!D*#$T*2D["BLC96YD M:68*(`D)<V1R86TP7V5C8V-F9R`](#`["B`)"65C8U]O;B`](#`["B`)?0I` M0"`M-#(T+#<@*S0S,2PX($!`("-E;F1I9@H@"2`J('!R;V=R86T@86QL('1H M92!R96=I<W1E<G,N"B`)("H@+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM M+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2HO"B`* M+2-D969I;F4@;71S9')A;3`H<F5G+"!D871A*2`@;71D8W(H;65M8V9G82QR M96<I.VUT9&-R*&UE;6-F9V0L9&%T82D**R-D969I;F4@;71S9')A;3`H<F5G M+"!D871A*2`@("!M=&1C<BAM96UC9F=A+')E9RD[;71D8W(H;65M8V9G9"QD M871A*0HK(V1E9FEN92!M9G-D<F%M,"AR96<L(&1A=&$I("![(&UT9&-R*&UE M;6-F9V$L<F5G*3MD871A(#T@;69D8W(H;65M8V9G9"D[('T*(`DO*B!D:7-A M8FQE(&UE;6-O;G1R;VQL97(@<V@=7!D871E<R!W;W)K("HO"B`);71S9')A M;3`H(&UE;5]M8V]P=#$L(#`@*3L*(`I`0"`M-#0W+#$P("LT-34L,3`@0$`@ M(V5N9&EF"B`)+RH@4T1204T@:&%V92!A('!O=V5R(&]N(&1E;&%Y+`D@-3`P M(&UI8W)O('-H;W5L9"!D;R`J+PH@"75D96QA>2@U,#`I.PH@"7-D<F%M,%]C M9F<@/2!31%)!33!?0T9'7T1#12!(%-$4D%-,%]#1D=?0E)01B@Q*2!(%-$ M4D%-,%]#1D=?14-#1$0@?"!31%)!33!?0T9'7T5-1%5,4CL*+0EI9B`H96-C M7V]N*0HM"0ES9')A;3!?8V9G('P](%-$4D%-,%]#1D=?345-0TA+.PH@"6UT M<V1R86TP*&UE;5]M8V]P=#$L('-D<F%M,%]C9F<I.PHM"BLC:69D968@0T]. M1DE'7T5#0PHK"6EF("AE8V-?;VXI('!R;V=R86U?96-C*#`L('1O=&%L7W-I M>F4L(#`I.PHK(V5N9&EF"B`)<F5T=7)N("AT;W1A;%]S:7IE*3L*('T*(`I` M0"`M-CDV+#@@*S<P-"PV($!`('9O:60@<')O9W)A;5]T<C`@*'5N<VEG;F5D M(&QO;F<J(&1I;6U?<&*(`H@=F]I9"!P<F]G<F%M7W1R,2`H=F]I9"D["B`* M+79O:60@<')O9W)A;5]E8V,@*'5N<VEG;F5D(&QO;F<)(&YU;5]B>71E<RD[ M"BT*('5N<VEG;F5D"B!L;VYG("!P<F]G<F%M7V)X8W(H=6YS:6=N960@;&]N M9RH@9&EM;5]P;W!U;&%T960L"B`)"2`@('5N<VEG;F5D(&-H87(J(&EI8S!? M9&EM;5]A9&1R+`I`0"`M,3<X-2PT-R`K,3<Y,2PW-B!`0"`C96YD:68*(`ER M971U<FXH8F%N:U]B87-E7V%D9'(I.PH@?0H@"BUV;VED('!R;V=R86U?96-C M("AU;G-I9VYE9"!L;VYG"2!N=6U?8GET97,I"BLC96YD:68@+RH@0T].1DE' M7S0T,"`J+PHK"BLC9&5F:6YE(%-$4D%-7T5#0T-&1U]#13`)"3!X,#`X,#`P M,#`)+RH@14-#($-O<G)E8W1I;VX@16YA8FQE(&9O<B!"86YK(#`)*B**R-D M969I;F4@4T1204U?14-#0T9'7T-%,0D),'@P,#0P,#`P,`DO*B!%0T,@0V]R M<F5C=&EO;B!%;F%B;&4@9F]R($)A;FL@,0DJ+PHK(V1E9FEN92!31%)!35]% M0T-#1D=?0T4R"0DP>#`P,C`P,#`P"2\J($5#0R!#;W)R96-T:6]N($5N86)L M92!F;W(@0F%N:R`R"2HO"BLC9&5F:6YE(%-$4D%-7T5#0T-&1U]#13,)"3!X M,#`Q,#`P,#`)+RH@14-#($-O<G)E8W1I;VX@16YA8FQE(&9O<B!"86YK(#,) M*B**PHK(V1E9FEN92!31%)!35]%0T-%4U)?15)23U)?34%32R`@("`@("`@ M(#!X1D9&,$8P,#`@("`@("`O*B!!;&P@<&]S<VEB;&4@14-#(&5R<F]R<R`J M+PHK(V1E9FEN92!%0T-?5$535%]604Q512`P>&%F9F5A9F9E"BL**R\J(`HK M("H@4')E<&%R92!F;W(@14-#(&]P97)A=&EO;@HK("H@4W1E<"`Q.B!%;F%B M;&4@14-#(&=E;F5R871I;VX@8G5T(&YO="!C:&5C:W,**R`J(%-T97`@,CH@ M1FEL;"!A;&P@;65M;W)Y"BL@*B!3=&5P(#,Z($5N86)L92!%0T,@9V5N97)A M=&EO;B!A;F0@8VAE8VMS"BL@*B!/;FQY('!R;V=R86UM960@9F]R(&%N9"!T M97-T960@;VX@82!04$,T,#5'4'(@8F]A<F0@=7-I;F<@;VYL>2!B86YK(#`@ M86YD(#,R(&)I="!W:61E("$A(0HK("HO"BMV;VED('!R;V=R86U?96-C("AV M;VED("IB86YK7V)A<V5?861D<BP@=6YS:6=N960@;&]N9R!N=6U?8GET97,L M(&EN="!B86YK*0H@>PHM"75N<VEG;F5D(&QO;F<@8F%N:U]B87-E7V%D9'([ M"B`)=6YS:6=N960@;&]N9R!C=7)R96YT7V%D9')E<W,["B`)=6YS:6=N960@ M;&]N9R!E;F1?861D<F5S<SL*(`EU;G-I9VYE9"!L;VYG(&%D9')E<W-?:6YC M<F5M96YT.PH@"75N<VEG;F5D(&QO;F<@8V9G,#L**PEI9BAB86YK("$](#`I M('L**PD)<')I;G1F*")<;B5S.B!O;FQY(&)A;FL@,"!S=7!P;W)T960B+"`@ M7U]&54Y#5$E/3E]?*3L**PE]"B`*(`DO*@H@"2`J(&=E="!-96UO<GD@0V]N M=')O;&QE<B!/<'1I;VYS(#`@9&%T80H@"2`J+PHM"6UF<V1R86TH;65M7V-F M9S`L(&-F9S`I.PHM"BL);69S9')A;3`H;65M7VUC;W!T,2P@8V9G,"D["BL) M"BL)8V9G,"`F/2!^4T1204TP7T-&1U]%34153%(@)B!^4T1204TP7T-&1U]- M14U#2$L["BLC:69D968@1$5"54<**PEP<FEN=&8H(B5S.B!L96YG=&@@,'@E M>"!B>71E<R!B86YK7V)A<V5?861D<B`E<%QN(BP@(%]?1E5.0U1)3TY?7RP@ M(&YU;5]B>71E<RP@8F%N:U]B87-E7V%D9'(I.PHK"7!R:6YT9B@B)7,Z(&-F M9S`@9&ES86)L92!C:&5C:VEN9R`M/B`P>"4P.'A<;B(L("!?7T953D-424]. M7U\L("!C9F<P*3L**R-E;F1I9@H@"2\J"B`)("H@<F5S970@=&AE(&)A;FM? M8F%S92!A9&1R97-S"B`)("HO"BT)8F%N:U]B87-E7V%D9'(@/2!#1D=?4T12 M04U?0D%313L**PEM='-D<F%M,"AM96U?96-C8V8L("`P*3L@("`@("`@("`@ M+RH@9&ES86)L92!C;W)R96-T:6]N("HO"BL);71S9')A;3`H;65M7V5C8V5R M<BP@4T1204U?14-#15-27T524D]27TU!4TLI.R`O*B!#;&5A<B!A;&P@97)R M;W)S("HO"BL);71S9')A;3`H;65M7VUC;W!T,2P@8V9G,"D["B`*+0EI9B`H M*&-F9S`@)B!31%)!35]#1D<P7TU#2$M?34%32RD@(3T@4T1204U?0T9',%]- M0TA+7TY/3BD@>PHM"0EM='-D<F%M*&UE;5]C9F<P+"`H8V9G,"`F('Y31%)! M35]#1D<P7TU#2$M?34%32RD@?`HM"0D)4T1204U?0T9',%]-0TA+7T=%3BD[ M"BL)861D<F5S<U]I;F-R96UE;G0@/2`T.PHK"6-U<G)E;G1?861D<F5S<R`] M("AU;G-I9VYE9"!L;VYG*2AB86YK7V)A<V5?861D<BD["BL)96YD7V%D9')E M<W,@/2`H=6YS:6=N960@;&]N9RDH8F%N:U]B87-E7V%D9'(I("L@;G5M7V)Y M=&5S.PH@"BT)"6EF("@H8V9G,"`F(%-$4D%-7T-&1S!?1$U71%]-05-+*2`] M/2!31%)!35]#1D<P7T1-5T1?,S(I('L*+0D)"6%D9')E<W-?:6YC<F5M96YT M(#T@-#L*+0D)?2!E;'-E('L*+0D)"6%D9')E<W-?:6YC<F5M96YT(#T@.#L* M+0D)?0HK"7=H:6QE("AC=7)R96YT7V%D9')E<W,@/"!E;F1?861D<F5S<RD@ M>PHK"0DJ*"AU;G-I9VYE9"!L;VYG*BEC=7)R96YT7V%D9')E<W,I(#T@,#L* M*PD)8W5R<F5N=%]A9&1R97-S("L](&%D9')E<W-?:6YC<F5M96YT.PHK"7T* M(`HM"0EC=7)R96YT7V%D9')E<W,@/2`H=6YS:6=N960@;&]N9RDH8F%N:U]B M87-E7V%D9'(I.PHM"0EE;F1?861D<F5S<R`]("AU;G-I9VYE9"!L;VYG*2AB M86YK7V)A<V5?861D<BD@*R!N=6U?8GET97,["BL);71S9')A;3`H;65M7V5C M8V5R<BP@4T1204U?14-#15-27T524D]27TU!4TLI.R`O*B!#;&5A<B!A;&P@ M97)R;W)S("HO"B`*+0D)=VAI;&4@*&-U<G)E;G1?861D<F5S<R`(&5N9%]A M9&1R97-S*2!["BT)"0DJ*"AU;G-I9VYE9"!L;VYG*BEC=7)R96YT7V%D9')E M<W,I(#T@,'@P,#`P,#`P,#L*+0D)"6-U<G)E;G1?861D<F5S<R`K/2!A9&1R M97-S7VEN8W)E;65N=#L*+0D)?0HK(VEF9&5F($1%0E5'"BL)<')I;G1F*"(E M<SH@8V9G,"!E;F%B;&4@8VAE8VMI;F=<;B(L("!?7T953D-424].7U\I.PHK M(V5N9&EF"BL);71S9')A;3`H;65M7V5C8V-F+"!31%)!35]%0T-#1D=?0T4P M*3L@("`@("`@("`O*B!E;F%B;&4@8V]R<F5C=&EO;B`J+PHK"7!R:6YT9B@B M14-#("(I.PH@"BT)"6UT<V1R86TH;65M7V-F9S`L("AC9F<P("8@?E-$4D%- M7T-&1S!?34-(2U]-05-+*2!"BT)"0E31%)!35]#1D<P7TU#2$M?0TA+*3L* M*R-I9F1E9B!$14)51PHK"7L@+RH@02!S;6%L;"!S86YI='D@8VAE8VL@*B* M*PD)=6YS:6=N960@;&]N9R`J8VAE8VL["BL)"6-H96-K/2`H=6YS:6=N960@ M;&]N9R`J*6)A;FM?8F%S95]A9&1R.PHK"0DJ8VAE8VL]14-#7U1%4U1?5D%, M544["BL)"6EF*"IC:&5C:R`A/2!%0T-?5$535%]604Q512D**PD)"7!R:6YT M9B@B)7,Z(&-H96-K:6YG(&%T("5P(&ES(#!X)7@@9F%I;&5D7&XB+"`@7U]& M54Y#5$E/3E]?+"!C:&5C:RP@*F-H96-K*3L*(`E]"BLC96YD:68)"B!]"B`* M+2-E;F1I9B`O*B!#3TY&24=?-#0P("HO"BT*("-E;F1I9B`O*B!#3TY&24=? ..4U!$7T5%4%)/32`J+PH` ` end