On Jul 7, 2008, at 2:02 PM, Wolfgang Denk wrote:
In message 1215447465.12657.15.camel@localhost you wrote:
I just extended the fsl_i2c.c driver that already uses a precomputed
Yes, I know. I never understood what such a complicated driver for sich a simple protocol was good for, especially as we don't do multimegabytepersecond transfers over such a bus.
The driver is no more complicated than the hardware itself. The Freescale I2C controller has a complicated, screwball method for setting the I2C bus speed, and the driver tries to simplify that as much as possible. Setting the I2C bus speed *may* be important on some boards with flaky I2C devices.
Accurate? There is no requirement to be "accurate" anywhere in the I2C protocol.
Some devices cannot handle certain bus speeds, and some devices may work better at higher bus speeds, so it may be important to control the bus speed accurately.
However, Luigi's patch is bad because it modifies a common file for a specific board. I'm going to NAK it.