Grant Likely wrote:
On 2/27/07, Txema Lopez tlopez@aotek.es wrote:
Hi all, This patch, for the 1.2.0 version, adds support for the csb535fs board embedded in a csb935fs breakout board. The set is known as i.MX21 Litekit.
With a quick perusal, the patch looks mostly okay. Unfortunately, it's inconvenient to review because it was sent as a gzipped attachment instead of inline (I can't just hit 'reply' and start typing comments).
I'm sorry, the patch size is more than the 40k U-Boot's limit, so ...
Here are some general comments:
- You should add your copyright to all new files that you've added.
At the moment, your copyright only appears on a few of the new files.
The cpu/arm926ejs/imx21 files have been copied from the cpu/arm920t/imx with a few modifications, so in the files with minor changes I've left the old copyright.
- Where did include/asm-arm/arch-imx21/imx21-regs.h come from? There
is no copyright notice on it at all.
It is a modification of include/asm-arm/arch-imx/imx-regs.h
- There's a fair bit of inconsistent whitespace (intermixed space and
tab characters).
Please, could you be more explicit and tell me where these mistakes are .
- I do wonder at the amount of boilerplate required for each new board
port (but that's a longer ranged questions directed at the whole of u-boot).
Me too.
Best regards,