Re: [U-Boot] Odd value for I2C_TIMEOUT in fsl_i2c.c

Dear Timur Tabi,

In message 4A9FDF1E.4090908@freescale.com you wrote:

Currently we define I2C_TIMEOUT like this:

#define I2C_TIMEOUT (CONFIG_SYS_HZ / 4)

= 250, that is.

CONFIG_HZ is 1000, so I2C_TIMEOUT is equal to 250. However, the way it's used, 250 isn't the number of ticks per second, it's used as number of microseconds. If CONFIG_HZ is changed to 100, does that mean that we want to call usec2ticks(25)?

CONFIG_SYS_HZ is a constant of 1000. We do not change constants.

Surely, one millisecond is not too long of a timeout?

It definitely depends which sort of timeout this is.

I guess there is some specification?

Best regards,

Wolfgang Denk