8 Jun
2020
8 Jun
'20
7:05 p.m.
On 6/8/20 2:24 AM, Michal Simek wrote:
It is in u-boot mainline from February. Then we had to fix it in April.
Do you have a link/commit hash for said fix?
In the middle of this I have seen IIC one patchset which improves hex handling which is likely better way then this.
Same for this.
I am fine with reverting this patch but I would also like to see more comments in the code to say that we shouldn't really change this.
This seems like a larger issue. There is a lot of code in U-Boot implementing the C standard library, especially the string library. Should we have a comment in each file which says something like "The functions here implement the C standard, think carefully before making semantic changes"?
--Sean