Re: [U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash

Haavard,

Looks good to me, except...

...

+static const struct stmicro_spi_flash_params

stmicro_spi_flash_table[] = {

...

• {

• .idcode1 = STM_ID_M25P16,
  

• .page_size = 256,
  

• .pages_per_sector = 256,
  

• .nr_sectors = 32,
  

• .name = "M25P16",
  

• },
  

• {

• .idcode1 = STM_ID_M25P20,
  

• .page_size = 256,
  

• .pages_per_sector = 256,
  

• .nr_sectors = 4,
  

• .name = "M25P20",
  

• },
  

• {

• .idcode1 = STM_ID_M25P32,
  

• .page_size = 256,
  

• .pages_per_sector = 256,
  

• .nr_sectors = 64,
  

• .name = "M25P32",
  

• },
  

• {

• .idcode1 = STM_ID_M25P40,
  

• .page_size = 256,
  

• .pages_per_sector = 256,
  

• .nr_sectors = 8,
  

• .name = "M25P40",
  

• },
  

• {

• .idcode1 = STM_ID_M25P64,
  

• .page_size = 256,
  

• .pages_per_sector = 256,
  

• .nr_sectors = 128,
  

• .name = "M25P64",
  

• },
  

• {

• .idcode1 = STM_ID_M25P80,
  

• .page_size = 256,
  

• .pages_per_sector = 256,
  

• .nr_sectors = 16,
  

• .name = "M25P80",
  

• },
  

• {

• .idcode1 = STM_ID_M25P128,
  

• .page_size = 256,
  

• .pages_per_sector = 1024,
  

• .nr_sectors = 64,
  

• .name = "M25P128",
  

• },
  

+};

The indentation is a bit weird here. Please use tabs only.

The indentation is generated by "indent -npro -kr -ts8 -sob -l80 -ss -ncs "$@"".

Who will apply this, btw?

I will apply this, if no one else do it.

Regards, TsiChung