Subject: Re: Cannot boot mx6qsabred with 2019.07-rc2
On Thu, May 23, 2019 at 1:11 PM Jagan Teki jagan@amarulasolutions.com wrote:
Don't know whether this is SPL size issue or not? can you try SPL_OF_PLATDATA and TINY* I can see the size reduced with 64512 bytes (one build issue on fdtdec_get_int undefined)
Yes, it does not build with CONFIG_SPL_OF_PLATDATA:
lib/built-in.o: In function `fdtdec_parse_phandle_with_args': /home/fabio/u-boot/lib/fdtdec.c:788: undefined reference to `fdtdec_get_int' drivers/built-in.o: In function `fsl_esdhc_probe': /home/fabio/u-boot/drivers/mmc/fsl_esdhc.c:1480: undefined reference to `fdtdec_get_int' /home/fabio/u-boot/drivers/mmc/fsl_esdhc.c:1482: undefined reference to `fdtdec_get_int' /home/fabio/u-boot/drivers/mmc/fsl_esdhc.c:1485: undefined reference to `fdtdec_get_int' scripts/Makefile.spl:404: recipe for target 'spl/u-boot-spl' failed make[1]: *** [spl/u-boot-spl] Error 1
Need the following patch.
diff --git a/lib/Makefile b/lib/Makefile index 09c45b8122..66ab6295a5 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -88,7 +88,7 @@ obj-y += crc32.o obj-$(CONFIG_CRC32C) += crc32c.o obj-y += ctype.o obj-y += div64.o -obj-$(CONFIG_OF_LIBFDT) += fdtdec.o +obj-$(CONFIG_OF_LIBFDT) += fdtdec.o fdtdec_common.o obj-y += hang.o obj-y += linux_compat.o obj-y += linux_string.o
Thanks for the suggestions, but at this point I prefer to go with the removal of CONFIG_SPL_DM.
Some drivers needs converted to use OF_PLATDATA, with remove the libfdt api in fsl_esdhc driver, the size shrinked from ~70KB to ~60KB with OF_PLATDATA.
Regards, Peng.
For 2019.07 it would be really nice if we could fix these two issues:
Allow to load a FIT image via Serial Download Protocol
Detect the SPL size overflow in build-time